SequenceBuilder: add .Reset() method and use it during merge#19567
Merged
AskAlexSharov merged 14 commits intomainfrom Mar 4, 2026
Merged
SequenceBuilder: add .Reset() method and use it during merge#19567AskAlexSharov merged 14 commits intomainfrom
AskAlexSharov merged 14 commits intomainfrom
Conversation
JkLondon
approved these changes
Mar 2, 2026
sudeepdino008
pushed a commit
that referenced
this pull request
Mar 4, 2026
Problem: <img width="1437" height="1233" alt="Screenshot 2026-03-02 at 17 20 26" src="https://github.com/user-attachments/assets/29993bd6-2a23-4c49-946c-62b390014818" /> In PR: - re-use 1 Builder object for many EF merges and many EF builds (in II.mergeFiles) - moved `Merge` method from `Reader` to `Builder` - moved reusable iterators for `Merge` method inside `Builder` object - “alloc=2.7g sys=5.4g” -> “alloc=2.7g sys=2.7g” (during large .rf file merge) --------- Co-authored-by: info@weblogix.biz <admin@10gbps.weblogix.it>
sudeepdino008
pushed a commit
that referenced
this pull request
Mar 4, 2026
Problem: <img width="1437" height="1233" alt="Screenshot 2026-03-02 at 17 20 26" src="https://github.com/user-attachments/assets/29993bd6-2a23-4c49-946c-62b390014818" /> In PR: - re-use 1 Builder object for many EF merges and many EF builds (in II.mergeFiles) - moved `Merge` method from `Reader` to `Builder` - moved reusable iterators for `Merge` method inside `Builder` object - “alloc=2.7g sys=5.4g” -> “alloc=2.7g sys=2.7g” (during large .rf file merge) --------- Co-authored-by: info@weblogix.biz <admin@10gbps.weblogix.it>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
In PR:
Mergemethod fromReadertoBuilderMergemethod insideBuilderobject